Skip to content

fix: clarify difference between instance and definition references - #1716

Merged
jsolaas merged 1 commit into
mainfrom
chore/clarify-references
Aug 13, 2026
Merged

fix: clarify difference between instance and definition references#1716
jsolaas merged 1 commit into
mainfrom
chore/clarify-references

Conversation

@jsolaas

@jsolaas jsolaas commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This changes instance references to be required, while definition
references are optional. It also changes the instance reference from
process simulation to pipeline by removing the TARGET key.

@jsolaas
jsolaas requested a review from a team as a code owner August 13, 2026 07:18
@jsolaas
jsolaas force-pushed the chore/clarify-references branch from 3e77912 to 4b484d7 Compare August 13, 2026 07:19
This changes instance references to be required, while definition
references are optional. It also changes the instance reference from
process simulation to pipeline by removing the TARGET key.
@jsolaas
jsolaas force-pushed the chore/clarify-references branch from 4b484d7 to 5d91eae Compare August 13, 2026 07:28
@jsolaas jsolaas changed the title fix!: clarify difference between instance and definition references fix: clarify difference between instance and definition references Aug 13, 2026
@tj098895

Copy link
Copy Markdown
Contributor

Does this lead to change in YAML? Before/after example?

@tj098895

Copy link
Copy Markdown
Contributor

So, this will make it possible to use "any reference" whenever a reference is needed, so that when we parse and validate - we will always need to check that the type is correct and supported? E.g. to not reference to a process unit when a pipeline is expected etc? Or was this already the case, but never checked?

@tj098895 tj098895 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I love when stuff I had thought of fixing just gets fixed :)

@jsolaas

jsolaas commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

So, this will make it possible to use "any reference" whenever a reference is needed, so that when we parse and validate - we will always need to check that the type is correct and supported? E.g. to not reference to a process unit when a pipeline is expected etc? Or was this already the case, but never checked?

Always the case, not sure about the check though. We should be able to check that.

@jsolaas
jsolaas merged commit faec744 into main Aug 13, 2026
23 checks passed
@jsolaas
jsolaas deleted the chore/clarify-references branch August 13, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants